[ADD] estate: Add initial module structure with property model #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nifest. Created 'estate_property' model and fields.
|
|
|
Hello, can you please ensure that your runbot is green 😄 |
added 3 commits
December 16, 2025 14:57
Also added access rights for estate.property model
lost-odoo
requested changes
Dec 16, 2025
lost-odoo
left a comment
lost-odoo
left a comment
There was a problem hiding this comment.
Hello, I already made a small review. Not a big deal but just some nitpicking stuff that we try to avoid. 😄
|
Also please don't forget to make one commit per chapter. Try to make a correct title. Don't hesitate to amend or squash your commits. |
added 2 commits
December 18, 2025 09:51
Added estate_property_views.xml which contains list and form views Added a separate estate_property_search_view.xml for search with filters for active and availability as well as group by based on postcode. Also addressed code review comments.
Added estate.property.type model which specifies the type of property. Eg: House/Apartment Added estate.property.tag model to indicate the tags(cozy, renovated) for each property Added estate.property.offer model which indicates the offers for each property. Also added views for each model mentioned above.
SurryaT10
force-pushed
the
19.0-estate-sutha
branch
from
f23d67c to
f11fc50
Compare
|
Hey don't forget to close all the comments I did on the review when you did them 😄 |
total_area field is based on the size of both garden_area and living_area best_offer field is based on the max price among the list of offers Also added validity and deadline for the offers as a computed and inverse function impacting each other.
SurryaT10
force-pushed
the
19.0-estate-sutha
branch
from
d33c5b0 to
e512458
Compare
added 2 commits
December 19, 2025 09:19
Added Sold and Cancel buttons: When a property is sold it cannot be canceled When a property is canceled it cannot be sold Added offer accept and rejected icon button: When an offer is accepted: 1. The selling price is automatically updated by button actions 2. Status changes to 'Offer Accepted' 3. Rejects all other offers Added an onchange, which updates the status to 'Offer Received' when there is an offer.
Added SQL constraints for expected_price, selling_price, property_tag_name and property_type_name Added python constraint for selling_price to be >= 90% of expected_price unless it is 0.0
lost-odoo
requested changes
Dec 19, 2025
SurryaT10
force-pushed
the
19.0-estate-sutha
branch
from
9a4342b to
b5bcfe4
Compare
Added ordering for the following: property: Descending by ID offer: Descending by price tag: Name type: Name Added sequence ordering for type Added color field for property tag. Added invisible attribute for Sold, Cancel, Accept, Reject buttons Added color decorations for list view. Added offer count button to show the list of offers for a property type Fixed code review changes.
SurryaT10
force-pushed
the
19.0-estate-sutha
branch
from
b5bcfe4 to
726eda7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialized Estate module and created 'estate_property' model.